Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: refactor to avoid unsafe array iteration #37654

Merged
merged 1 commit into from
Mar 13, 2021
Merged

http: refactor to avoid unsafe array iteration #37654

merged 1 commit into from
Mar 13, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 8, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Mar 8, 2021
@Lxxyx Lxxyx added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Mar 8, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36534/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36670/

@aduh95
http: refactor to avoid unsafe array iteration
fc6426c 
PR-URL: nodejs#37654
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@aduh95
Copy link
Contributor Author

aduh95 commented Mar 13, 2021

Landed in fc6426c

@aduh95 aduh95 closed this Mar 13, 2021
@aduh95 aduh95 merged commit fc6426c into nodejs:master Mar 13, 2021
@aduh95 aduh95 deleted the http-array-iteration branch March 13, 2021 09:39
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@aduh95 @danielleadams
http: refactor to avoid unsafe array iteration
77c5c2f 
PR-URL: #37654
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@aduh95 @danielleadams
http: refactor to avoid unsafe array iteration
6688569 
PR-URL: #37654
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aduh95 @nodejs-github-bot @Lxxyx @RaisinTen @targos